Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2504)

Unified Diff: crosstest/test_global_main.cpp

Issue 1506653002: Subzero: Add Non-SFI support for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Refactor the link commands Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: crosstest/test_global_main.cpp
diff --git a/crosstest/test_global_main.cpp b/crosstest/test_global_main.cpp
index 5383cb7a0f1088dee990180e8e395123a7b30364..6b4eec777ed7598e65656e1bdea53f190292bd8d 100644
--- a/crosstest/test_global_main.cpp
+++ b/crosstest/test_global_main.cpp
@@ -39,6 +39,11 @@ struct Data *ExternName4 = &SimpleData;
double ExternName5 = 3.44e26;
int main(int argc, char **argv) {
+ // Prevent pnacl-opt from deleting "unused" globals.
John 2016/01/04 21:33:51 why wasn't this a problem before?
Jim Stichnoth 2016/01/04 23:32:12 It wasn't a problem presumably because native and
+ if (argc < 0) {
+ std::cout << &ExternName1 << &ExternName2 << &ExternName3 << &SimpleData
+ << &ExternName4 << ExternName5;
+ }
size_t TotalTests = 0;
size_t Passes = 0;
size_t Failures = 0;

Powered by Google App Engine
This is Rietveld 408576698