Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/IceELFSection.h

Issue 1506653002: Subzero: Add Non-SFI support for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fill in part of the lit test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceELFSection.h
diff --git a/src/IceELFSection.h b/src/IceELFSection.h
index 6d24e4af5e13ba3d060ecdb7186c2f8c3fed2499..369c14d07d9aae9a0a430dfb94b41e7f988046f5 100644
--- a/src/IceELFSection.h
+++ b/src/IceELFSection.h
@@ -352,10 +352,11 @@ void ELFRelocationSection::writeData(const GlobalContext &Ctx, ELFStreamer &Str,
const ELFSymbolTableSection *SymTab) {
for (const AssemblerFixup &Fixup : Fixups) {
const ELFSym *Symbol;
+ constexpr Assembler *Asm = nullptr;
John 2015/12/22 15:44:38 Why not declaring this inside the scope where it i
Jim Stichnoth 2015/12/28 07:54:07 Done.
if (Fixup.isNullSymbol())
Symbol = SymTab->getNullSymbol();
else
- Symbol = SymTab->findSymbol(Fixup.symbol(&Ctx));
+ Symbol = SymTab->findSymbol(Fixup.symbol(&Ctx, Asm));
if (!Symbol)
llvm::report_fatal_error("Missing symbol mentioned in reloc");

Powered by Google App Engine
This is Rietveld 408576698