runtime/szrt_asm_x8664.s - Issue 1506653002: Subzero: Add Non-SFI support for x86-32.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/szrt_asm_x8664.s

Issue 1506653002: Subzero: Add Non-SFI support for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fill in part of the lit test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ##===- subzero/runtime/szrt_asm_x8664.s - Subzero runtime asm helpers------===##

	2 ##

	3 ## The Subzero Code Generator

	4 ##

	5 ## This file is distributed under the University of Illinois Open Source

	6 ## License. See LICENSE.TXT for details.

	7 ##

	8 ##===----------------------------------------------------------------------===##

	9 ##

	10 ## This file provides an assembly implementation of various helpers needed by

	11 ## the Subzero x8664 runtime.

	12 ##

	13 ##===----------------------------------------------------------------------===##

	14

	15 .text

	16 .p2align 5,0xf4
	John 2015/12/22 15:44:38 For x8664 I don't think we will need this file as For x8664 I don't think we will need this file as PIC addressing is very easy to be encoded (thanks, AMD! :)) Same for the ARM32.s What do you think about not adding these quasi-empty files until they are needed? Jim Stichnoth 2015/12/28 07:54:07 I'd prefer to keep these .s files just because it Show quoted text On 2015/12/22 15:44:38, John wrote: > For x8664 I don't think we will need this file as PIC addressing is very easy to > be encoded (thanks, AMD! :)) Same for the ARM32.s > > What do you think about not adding these quasi-empty files until they are > needed? I'd prefer to keep these .s files just because it simplifies the scripts for building the target runtime - no special code to decide whether a given architecture uses a .s file. I was thinking beyond just PIC though, but who knows if we will ever need more. Maybe if we wanted to hand-generate helper functions for numeric conversion, e.g.? What do you think?
OLD	NEW

« runtime/szrt_asm_arm32.s ('K') | « runtime/szrt_asm_x8632.s ('k') | src/IceAssemblerARM32.cpp » ('j') | src/IceAssemblerX86BaseImpl.h » ('J')