Integrate ErrorConsole with Apps Dev Tool

chrome/browser/ui/webui/extensions/extension_error_ui_util.h

Index: chrome/browser/ui/webui/extensions/extension_error_ui_util.h
diff --git a/chrome/browser/ui/webui/extensions/extension_error_ui_util.h b/chrome/browser/ui/webui/extensions/extension_error_ui_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..de80c950c90487d7dc3446122201c66c1165ba23
--- /dev/null
+++ b/chrome/browser/ui/webui/extensions/extension_error_ui_util.h
@@ -0,0 +1,34 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_ERROR_UI_UTIL_H_
+#define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_ERROR_UI_UTIL_H_
+
+#include <string>
+
+#include "base/callback.h"
+#include "base/strings/string16.h"

[Dan Beam, 2014/02/11 02:43:49]

move both string and string16 includes to .cc

[Dan Beam, 2014/02/11 18:54:43]

^ and this

[Devlin, 2014/02/11 19:26:45]

Done.

[Devlin, 2014/02/11 19:26:45]

Done.

+
+class Profile;
+
+namespace base {
+class DictionaryValue;
+}
+
+namespace extensions {
+namespace error_ui_util {
+
+typedef base::Callback<void(const base::DictionaryValue&)>
+    JavascriptResponseCallback;

[Dan Beam, 2014/02/11 02:43:49]

^ is this used outside this file?

[Dan Beam, 2014/02/11 18:54:43]

and this

[Devlin, 2014/02/11 19:26:45]

No, but I've been told before that doing this improves readability, even in the
function declaration.  Renamed it to RequestFileSourceCallback to be slightly
more accurate.  Of course, it's always OWNERS preference, so if you'd like me to
remove the typedef so we don't have to include callback.h here, I'm happy to.

+

[Dan Beam, 2014/02/11 02:43:49]

doc comments

[Dan Beam, 2014/02/11 18:54:43]

and this

[Devlin, 2014/02/11 19:26:45]

Done.

+void HandleRequestFileSource(const base::DictionaryValue* args,
+                             Profile* profile,
+                             const JavascriptResponseCallback& response);
+
+void HandleOpenDevTools(const base::DictionaryValue* args);
+
+}  // namespace error_ui_util
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_ERROR_UI_UTIL_H_