Issue 150663005: Optimize redundant HCompareMap instructions with known successors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150663005: Optimize redundant HCompareMap instructions with known successors. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer

Modified:
6 years, 10 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Optimize redundant HCompareMap instructions with known successors. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19094

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -3 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/hydrogen-check-elimination.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	2 chunks	+17 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Hey Igor, This removes two redundant HCompareMap instructions in DeltaBlue, giving some 2-3% improvement. We ...

6 years, 10 months ago (2014-02-05 09:06:39 UTC) #1

Benedikt Meurer

6 years, 10 months ago (2014-02-05 09:31:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19094 (presubmit successful).