Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 150653010: Add unit test for unbalanced save and restores in pictures. (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add unit test for unbalanced save and restores in pictures. Committed: http://code.google.com/p/skia/source/detail?r=13430

Patch Set 1 #

Patch Set 2 : Add test case for no save, verify matrix doesn't get changed #

Patch Set 3 : remove extra newline #

Patch Set 4 : improve comments #

Patch Set 5 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -3 lines) Patch
M include/core/SkCanvas.h View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 2 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
6 years, 10 months ago (2014-02-12 15:35:27 UTC) #1
reed1
lgtm -- gimmie more!
6 years, 10 months ago (2014-02-12 16:26:09 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-13 15:07:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/150653010/150001
6 years, 10 months ago (2014-02-13 15:08:03 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 16:00:54 UTC) #5
Message was sent while issue was closed.
Change committed as 13430

Powered by Google App Engine
This is Rietveld 408576698