Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 150653004: Add gclient style cache_dir support for deps2git. (Closed)

Created:
6 years, 10 months ago by Ryan Tseng
Modified:
6 years, 10 months ago
Reviewers:
szager, agable, iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, agable, iannucci
Base URL:
https://chromium.googlesource.com/chromium/tools/deps2git.git@master
Visibility:
Public.

Description

Add gclient style cache_dir support for deps2git. Also - During clone, always pipe stdout to sys.stdout. This will not work as well when we want to multithread deps2git, but will be okay for now to get buildbot to not kill the process when checking out blink. BUG=339168 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=249599

Patch Set 1 #

Patch Set 2 : Put timeouts back in #

Total comments: 1

Patch Set 3 : Nit fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M deps2git.py View 1 2 4 chunks +24 lines, -4 lines 1 comment Download
M git_tools.py View 1 5 chunks +25 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Tseng
szager for review - ptal This does 2 things: 1. Add a --cached_dir flag so ...
6 years, 10 months ago (2014-02-07 00:45:26 UTC) #1
Ryan Tseng
Actually this makes more sense: szager for review on GetStatusOutput() iannucci for review on --cached_dir.
6 years, 10 months ago (2014-02-07 01:31:39 UTC) #2
agable
LGTM % nit. https://codereview.chromium.org/150653004/diff/30001/deps2git.py File deps2git.py (right): https://codereview.chromium.org/150653004/diff/30001/deps2git.py#newcode33 deps2git.py:33: url = url[idx+3:] separator = '://' ...
6 years, 10 months ago (2014-02-07 03:28:32 UTC) #3
Ryan Tseng
Fixed Szager: In the interest of landing bot_update.py today, I'm going to commit this patch ...
6 years, 10 months ago (2014-02-07 03:35:52 UTC) #4
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 10 months ago (2014-02-07 03:36:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/150653004/80001
6 years, 10 months ago (2014-02-07 03:36:20 UTC) #6
commit-bot: I haz the power
Change committed as 249599
6 years, 10 months ago (2014-02-07 03:36:27 UTC) #7
szager
6 years, 10 months ago (2014-02-07 14:09:29 UTC) #8
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/150653004/diff/80001/deps2git.py
File deps2git.py (right):

https://codereview.chromium.org/150653004/diff/80001/deps2git.py#newcode31
deps2git.py:31: separator = '://'
In general, use the urlparse package for url slicing and dicing.

Powered by Google App Engine
This is Rietveld 408576698