Fix heap-use-after-free in CXFA_PDFFontMgr::~CXFA_PDFFontMgr()

Fix heap-use-after-free in CXFA_PDFFontMgr::~CXFA_PDFFontMgr()

BUG=pdfium:306
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3b1707f50e4961c2a350243acbeaaafd89e22fca

[jun_fang, 2015-12-09 13:29:08]

jun_fang@foxitsoftware.com changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-12-09 13:29:08]

Hi Tom and Lei,

Please review this CL.

https://codereview.chromium.org/1506423002/diff/1/xfa/src/fxfa/src/app/xfa_fo...
File xfa/src/fxfa/src/app/xfa_fontmgr.cpp (left):

https://codereview.chromium.org/1506423002/diff/1/xfa/src/fxfa/src/app/xfa_fo...
xfa/src/fxfa/src/app/xfa_fontmgr.cpp:1872: pFDEFont->SetFontProvider(NULL);
We believe that PDFFontMgr always lives longer than DefFontMgr. During the
deconstruction of PDFFontMgr, DefFontMgr and the default fonts have been
released. So it doesn't need to inform the default font that PDFFontMgr is being
destroyed.

[Tom Sepez, 2015-12-09 19:12:58]

lgtm

[jun_fang, 2015-12-10 04:07:51]

Description was changed from

==========
Fix heap-use-after-free in CXFA_PDFFontMgr::~CXFA_PDFFontMgr()

BUG=pdfium:306
==========

to

==========
Fix heap-use-after-free in CXFA_PDFFontMgr::~CXFA_PDFFontMgr()

BUG=pdfium:306
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/3b1707f50e4961c2a350243acbeaaafd89e2...
==========

[jun_fang, 2015-12-10 04:07:54]

Committed patchset #1 (id:1) manually as
3b1707f50e4961c2a350243acbeaaafd89e22fca (presubmit successful).