Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1506353009: [es6] implement RegExp.@@search. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] implement RegExp.@@search. BUG=v8:4344 LOG=N R=littledan@chromium.org Committed: https://crrev.com/466da713c3e9e7583586933572d66c6bed1745f3 Cr-Commit-Position: refs/heads/master@{#32827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -21 lines) Patch
M src/js/regexp.js View 5 chunks +17 lines, -2 lines 0 comments Download
M src/js/string.js View 3 chunks +13 lines, -13 lines 0 comments Download
A + test/mjsunit/es6/string-search.js View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
5 years ago (2015-12-11 09:31:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506353009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506353009/1
5 years ago (2015-12-11 09:55:12 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-11 10:42:04 UTC) #5
Dan Ehrenberg
lgtm Looks like a good start; glad you put those TODOs in there. FWIW it's ...
5 years ago (2015-12-11 19:16:35 UTC) #6
Yang
On 2015/12/11 19:16:35, Dan Ehrenberg wrote: > lgtm > > Looks like a good start; ...
5 years ago (2015-12-14 09:38:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506353009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506353009/1
5 years ago (2015-12-14 09:39:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 10:22:26 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-14 10:22:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/466da713c3e9e7583586933572d66c6bed1745f3
Cr-Commit-Position: refs/heads/master@{#32827}

Powered by Google App Engine
This is Rietveld 408576698