Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1506343003: No GN phony rules when it matches outputs. (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
agrieve
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No GN phony rules when it matches outputs. Skip generating a short name phony rule for a target when the short name matches the target name. It's reasonable that an action named "foo" would generate a file called foo in the root build directory. R=agrieve@chromium.org Committed: https://crrev.com/936b61a117e5a35ccb996f586f5ac5f0c698ce61 Cr-Commit-Position: refs/heads/master@{#364395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M tools/gn/ninja_build_writer.cc View 2 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506343003/1
5 years ago (2015-12-10 00:01:19 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 00:41:07 UTC) #4
agrieve
On 2015/12/10 00:41:07, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-10 10:24:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506343003/1
5 years ago (2015-12-10 17:56:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 18:06:38 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 18:07:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/936b61a117e5a35ccb996f586f5ac5f0c698ce61
Cr-Commit-Position: refs/heads/master@{#364395}

Powered by Google App Engine
This is Rietveld 408576698