Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 15063005: Merge 198671 "Try fast-fetch rather than full fetch if drive::Fi..." (Closed)

Created:
7 years, 7 months ago by hashimoto
Modified:
7 years, 7 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 198671 "Try fast-fetch rather than full fetch if drive::Fi..." > Try fast-fetch rather than full fetch if drive::FileSystem::GetEntryInfo failed. > > GetEntryInfoByPath is not only used for querying an entry info, > but also for just testing the existence of an entry. > So, it is not always desirable to start full fetch when > it does not exist locally. > > The new implementation falls back to full fetch after all > when the parent directory's entry is not ready either. > This should not be an issue, however. > Existence testing most typically happens when user tries to > put a new file in a folder, in which case, the folder is > already opened in UI and hence loaded. > > BUG=236708 > TEST=the steps explained in BUG. > R=satorux@chromium.org > > Review URL: https://codereview.chromium.org/14838003 > > Patch from Kazuhiro Inaba <kinaba@chromium.org>;. TBR=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -52 lines) Patch
M chrome/browser/chromeos/drive/file_system.h View 1 chunk +11 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 3 chunks +28 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 8 chunks +69 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hashimoto
7 years, 7 months ago (2013-05-13 08:48:57 UTC) #1
hashimoto
7 years, 7 months ago (2013-05-13 08:49:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r199689.

Powered by Google App Engine
This is Rietveld 408576698