Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 1506203008: Allow background tab titles to use LCD AA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use new Skia API name Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index 34f422f8b1236189025e3e56a860ac2d22e5997e..63c8d9284b4767e4ea13b49a2c1f4c57267d82cd 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -1432,11 +1432,8 @@ void TabStrip::PaintChildren(const ui::PaintContext& context) {
Tabs selected_tabs;
{
- // TODO(pkasting): This results in greyscale AA for the tab titles. Work
- // with Mike Reed to fix, or else convert to passing the tabs a memory
- // canvas to paint on and then manually compositing.
ui::CompositingRecorder opacity_recorder(context, size(),
- GetInactiveAlpha(false));
+ GetInactiveAlpha(false), true);
PaintClosingTabs(tab_count(), context);
@@ -1494,7 +1491,7 @@ void TabStrip::PaintChildren(const ui::PaintContext& context) {
// Match the inactive tab opacity for non-pressed states. See comments in
// NewTabButton::PaintFill() for why we don't do this for the pressed state.
ui::CompositingRecorder opacity_recorder(context, size(),
- GetInactiveAlpha(true));
+ GetInactiveAlpha(true), false);
newtab_button_->Paint(context);
} else {
newtab_button_->Paint(context);

Powered by Google App Engine
This is Rietveld 408576698