Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1506203004: Reland of Downgrade lock icon for broken-HTTPS subresources (Closed)

Created:
5 years ago by estark
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jam, Nate Chapin, loading-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Downgrade lock icon for broken-HTTPS subresources (patchset #2 id:300001 of https://codereview.chromium.org/1497423002/ ) Reason for revert: Relanding since the speculative revert didn't seem to help with crbug.com/565540 Original issue's description: > Revert of Downgrade lock icon for broken-HTTPS subresources (patchset #11 id:200001 of https://codereview.chromium.org/1415923015/ ) > > Reason for revert: > Speculatively reverting to see if it makes https://code.google.com/p/chromium/issues/detail?id=565540 go away > > Note that this revert preserves the histogrammed > bad_message.h value that was added in CL 1415923015 > > Original issue's description: > > Downgrade lock icon for broken-HTTPS subresources > > > > This CL attaches a boolean to resource responses to indicate if they > > have certificate errors. If Blink sees a resource with a cert error, it > > notifies the renderer via FrameLoaderClient, who then notifies the > > browser, who treats the situation like mixed content. > > > > The browser (//content) ignores subresources with cert errors on HTTP > > pages, and subresources with the same cert errors as the main > > resource. This allows embedders to distinguish broken-HTTPS foo.com with > > a subresource from broken-HTTPS bar.com and broken-HTTPS foo.com with a > > subresource from broken-HTTPS foo.com. > > > > BUG=477868 > > > > Committed: https://crrev.com/8bfb78c859ab5993eada6db30e4de50aa7403f1c > > Cr-Commit-Position: refs/heads/master@{#362246} > > TBR=jochen@chromium.org,jww@chromium.org,mkwst@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=477868 > > Committed: https://crrev.com/51ea371ad45bb5887dacf7fca6fe0feef8941262 > Cr-Commit-Position: refs/heads/master@{#363388} TBR=jochen@chromium.org,jww@chromium.org,mkwst@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477868 Committed: https://crrev.com/910b457a9d91a7e8858121d4c199c301bb3e8f10 Cr-Commit-Position: refs/heads/master@{#364152}

Patch Set 1 #

Patch Set 2 : fix conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -64 lines) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 1 4 chunks +69 lines, -36 lines 0 comments Download
A chrome/test/data/ssl/page_with_dynamic_unsafe_image.html View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/data/ssl/page_with_unsafe_image.html View 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/ssl/ssl_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/ssl/ssl_policy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy.cc View 1 2 chunks +7 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 3 chunks +40 lines, -3 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 1 chunk +14 lines, -1 line 0 comments Download
M content/common/resource_messages.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/resource_response.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/resource_response_info.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/resource_response_info.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 3 chunks +60 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 1 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp View 1 2 chunks +47 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.cpp View 1 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
estark
Created Reland of Downgrade lock icon for broken-HTTPS subresources
5 years ago (2015-12-09 18:42:58 UTC) #1
jww
On 2015/12/09 18:42:58, estark wrote: > Created Reland of Downgrade lock icon for broken-HTTPS subresources ...
5 years ago (2015-12-09 18:46:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506203004/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506203004/300001
5 years ago (2015-12-09 20:51:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:300001)
5 years ago (2015-12-09 20:55:49 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 20:56:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/910b457a9d91a7e8858121d4c199c301bb3e8f10
Cr-Commit-Position: refs/heads/master@{#364152}

Powered by Google App Engine
This is Rietveld 408576698