Added a PolicyDomainDescriptor.

chrome/browser/extensions/api/storage/managed_value_store_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/storage/managed_value_store_cache.h"
 
 #include <set>

[bartfab (slow), 2013/05/21 12:10:56]

Nit: No longer used.

[Joao da Silva, 2013/05/21 17:50:14]

Done.

 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "chrome/browser/extensions/api/storage/policy_value_store.h"
 #include "chrome/browser/extensions/api/storage/settings_storage_factory.h"
 #include "chrome/browser/extensions/event_names.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/policy/policy_domain_descriptor.h"
+#include "chrome/browser/policy/policy_schema.h"
 #include "chrome/browser/policy/profile_policy_connector.h"
 #include "chrome/browser/policy/profile_policy_connector_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/value_store/value_store_change.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "chrome/common/extensions/permissions/api_permission.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
@@ skipping 47 matching lines @@
   if (type == chrome::NOTIFICATION_EXTENSIONS_READY)
     is_ready_ = true;
 
   if (!is_ready_)
     return;
 
   // TODO(joaodasilva): this currently only registers extensions that use
   // the storage API, but that still includes a lot of extensions that don't
   // use the storage.managed namespace. Use the presence of a schema for the
   // managed namespace in the manifest as a better signal, once available.
-
+  scoped_refptr<policy::PolicyDomainDescriptor> descriptor(
+      new policy::PolicyDomainDescriptor(policy::POLICY_DOMAIN_EXTENSIONS));
   const ExtensionSet* set =
       ExtensionSystem::Get(profile_)->extension_service()->extensions();
-  std::set<std::string> use_storage_set;
-  for (ExtensionSet::const_iterator it = set->begin();
-       it != set->end(); ++it) {
+  for (ExtensionSet::const_iterator it = set->begin(); it != set->end(); ++it) {
+    // TODO(joaodasilva): pass the parsed schema here, once available.
     if ((*it)->HasAPIPermission(APIPermission::kStorage))
-      use_storage_set.insert((*it)->id());
+      descriptor->SetComponent((*it)->id(), scoped_ptr<policy::PolicySchema>());
   }
 
   policy::ProfilePolicyConnector* connector =
       policy::ProfilePolicyConnectorFactory::GetForProfile(profile_);
-  connector->policy_service()->RegisterPolicyDomain(
-      policy::POLICY_DOMAIN_EXTENSIONS,
-      use_storage_set);
+  connector->policy_service()->RegisterPolicyDomain(descriptor);
 }
 
 ManagedValueStoreCache::ManagedValueStoreCache(
     Profile* profile,
     const scoped_refptr<SettingsStorageFactory>& factory,
     const scoped_refptr<SettingsObserverList>& observers)
     : weak_factory_(this),
       weak_this_on_ui_(weak_factory_.GetWeakPtr()),
       profile_(profile),
       event_router_(ExtensionSystem::Get(profile)->event_router()),
@@ skipping 225 matching lines @@
     continuation.Run();
 }
 
 policy::PolicyService* ManagedValueStoreCache::GetPolicyService() {
   policy::ProfilePolicyConnector* connector =
       policy::ProfilePolicyConnectorFactory::GetForProfile(profile_);
   return connector->policy_service();
 }
 
 }  // namespace extensions