Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: ui/views/controls/button/checkbox.h

Issue 15061006: views: Switch Checkbox over to LabelButton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: set the image for STATE_TOGGLED Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/button/checkbox.h
diff --git a/ui/views/controls/button/checkbox.h b/ui/views/controls/button/checkbox.h
index 3c739306eca578aa396955bfec4275dce73fe5b0..f43ab63ca94edc7aa8ea7567a86aedf18b277f56 100644
--- a/ui/views/controls/button/checkbox.h
+++ b/ui/views/controls/button/checkbox.h
@@ -9,44 +9,13 @@
#include "base/compiler_specific.h"
#include "base/string16.h"
-#include "ui/views/controls/button/text_button.h"
+#include "ui/views/controls/button/label_button.h"
namespace views {
-// A border with zero left inset.
-class VIEWS_EXPORT CheckboxNativeThemeBorder
- : public TextButtonNativeThemeBorder {
- public:
- explicit CheckboxNativeThemeBorder(views::NativeThemeDelegate* delegate)
- : TextButtonNativeThemeBorder(delegate),
- use_custom_insets_(false) {}
- virtual ~CheckboxNativeThemeBorder() {}
-
- // The insets apply to the whole view (checkbox + text), not just the square
- // with the checkmark in it. The insets do not visibly affect the checkbox,
- // except to ensure that there is enough padding between this and other
- // elements.
- virtual gfx::Insets GetInsets() const OVERRIDE;
-
- // Use the |custom_insets_| provided instead of those from the theme.
- void SetCustomInsets(const gfx::Insets& custom_insets);
-
- // Use the default insets and ignore any |custom_insets_| that may be set.
- void UseDefaultInsets();
-
- private:
- // Only used if |use_custom_insets_| is true.
- gfx::Insets custom_insets_;
-
- // Whether |custom_insets_| should be used in |GetInsets()|.
- bool use_custom_insets_;
-
- DISALLOW_COPY_AND_ASSIGN(CheckboxNativeThemeBorder);
-};
-
// A native themed class representing a checkbox. This class does not use
// platform specific objects to replicate the native platforms looks and feel.
-class VIEWS_EXPORT Checkbox : public TextButtonBase {
+class VIEWS_EXPORT Checkbox : public LabelButton {
public:
static const char kViewClassName[];
@@ -59,28 +28,20 @@ class VIEWS_EXPORT Checkbox : public TextButtonBase {
// Sets/Gets whether or not the checkbox is checked.
virtual void SetChecked(bool checked);
- bool checked() const { return checked_; }
+ bool checked() const { return state() == STATE_TOGGLED; }
protected:
// Overridden from View:
- virtual gfx::Size GetPreferredSize() OVERRIDE;
virtual const char* GetClassName() const OVERRIDE;
virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual void OnPaintFocusBorder(gfx::Canvas* canvas) OVERRIDE;
private:
// Overridden from Button:
virtual void NotifyClick(const ui::Event& event) OVERRIDE;
- // Overridden from TextButtonBase:
virtual ui::NativeTheme::Part GetThemePart() const OVERRIDE;
- virtual gfx::Rect GetThemePaintRect() const OVERRIDE;
virtual void GetExtraParams(
ui::NativeTheme::ExtraParams* params) const OVERRIDE;
- virtual gfx::Rect GetTextBounds() const OVERRIDE;
-
- // True if the checkbox is checked.
- bool checked_;
DISALLOW_COPY_AND_ASSIGN(Checkbox);
};

Powered by Google App Engine
This is Rietveld 408576698