views: Switch Checkbox over to LabelButton.

ui/views/controls/button/label_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/label_button.h"
 
 #include "base/logging.h"
 #include "grit/ui_resources.h"
 #include "ui/base/animation/throb_animation.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 278 matching lines @@
   return ui::NativeTheme::kPushButton;
 }
 
 gfx::Rect LabelButton::GetThemePaintRect() const {
   return GetLocalBounds();
 }
 
 ui::NativeTheme::State LabelButton::GetThemeState(
     ui::NativeTheme::ExtraParams* params) const {
   GetExtraParams(params);
-  switch(state()) {
+  switch (state()) {
     case STATE_NORMAL:   return ui::NativeTheme::kNormal;
     case STATE_HOVERED:  return ui::NativeTheme::kHovered;
     case STATE_PRESSED:  return ui::NativeTheme::kPressed;
     case STATE_DISABLED: return ui::NativeTheme::kDisabled;
+    case STATE_TOGGLED:  return ui::NativeTheme::kToggled;

[msw, 2013/05/16 22:40:05]

nit: I'd prefer this to come before STATE_DISABLED.

[tfarina, 2013/05/18 00:54:08]

ditto.

     case STATE_COUNT:    NOTREACHED() << "Unknown state: " << state();
   }
   return ui::NativeTheme::kNormal;
 }
 
 const ui::Animation* LabelButton::GetThemeAnimation() const {
 #if defined(OS_WIN)
   if (style() == STYLE_NATIVE_TEXTBUTTON &&
       GetNativeTheme() == ui::NativeThemeWin::instance()) {
     return ui::NativeThemeWin::instance()->IsThemingActive() ?
         hover_animation_.get() : NULL;
   }
 #endif
   return hover_animation_.get();
 }
 
 ui::NativeTheme::State LabelButton::GetBackgroundThemeState(
     ui::NativeTheme::ExtraParams* params) const {
   GetExtraParams(params);
   return ui::NativeTheme::kNormal;
 }
 
 ui::NativeTheme::State LabelButton::GetForegroundThemeState(
     ui::NativeTheme::ExtraParams* params) const {
   GetExtraParams(params);
   return ui::NativeTheme::kHovered;
 }
 
 void LabelButton::GetExtraParams(ui::NativeTheme::ExtraParams* params) const {

[msw, 2013/05/16 22:40:05]

Move this impl to match the changed decl ordering.

[tfarina, 2013/05/18 00:54:08]

Done.

   params->button.checked = false;
   params->button.indeterminate = false;
   params->button.is_default = is_default_;
   params->button.is_focused = HasFocus() && IsAccessibilityFocusable();
   params->button.has_border = style() == STYLE_NATIVE_TEXTBUTTON;
   params->button.classic_state = 0;
   params->button.background_color = GetNativeTheme()->GetSystemColor(
       ui::NativeTheme::kColorId_TextButtonBackgroundColor);
 }
 
 }  // namespace views