scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json - Issue 1506073002: Switch remaining bots to new Telemetry GPU isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

Issue 1506073002: Switch remaining bots to new Telemetry GPU isolate. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Undid more changes relative to original code. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/chromium_trybot.py ('K') | « scripts/slave/recipes/chromium_trybot.py ('k') | scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing.json » ('j') | scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_harness_failure.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json b/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

index 4839c77e8ca0fe8b693610d3b0847e1b7b0703d7..6b30935cace8f7e859922d9dc89f0dd275d98736 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

@@ -230,7 +230,7 @@

"linux_chromium_rel_ng",

"-v",

"//out/Release",

- "{\"additional_compile_targets\": [\"chromium_swarm_tests\"], \"files\": [\"foo.cc\"], \"test_targets\": [\"angle_unittests_run\", \"base_unittests\", \"chrome\", \"content_gl_tests_run\", \"gl_tests_run\", \"gl_unittests_run\", \"tab_capture_end2end_tests_run\", \"telemetry_gpu_test_run\"]}",

Ken Russell (switch to Gerrit) 2015/12/08 06:41:50 The removal of "chrome" as a compile target here a

+ "{\"additional_compile_targets\": [\"chromium_swarm_tests\"], \"files\": [\"foo.cc\"], \"test_targets\": [\"angle_unittests_run\", \"base_unittests\", \"content_gl_tests_run\", \"gl_tests_run\", \"gl_unittests_run\", \"tab_capture_end2end_tests_run\", \"telemetry_gpu_new_test_run\"]}",

"/path/to/tmp/json"

"cwd": "[SLAVE_BUILD]",