Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1506073002: Switch remaining bots to new Telemetry GPU isolate. (Closed)

Created:
5 years ago by Ken Russell (switch to Gerrit)
Modified:
5 years ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, Jamie Madill, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Switch remaining bots to new Telemetry GPU isolate. This removes all of the special handling in recipes for "Telemetry GPU tests". BUG=561863 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297922

Patch Set 1 #

Patch Set 2 : Add back in "gpu_test:1" tag. #

Patch Set 3 : Made failures of the entire harness produce invalid results again. #

Patch Set 4 : Rebased. #

Patch Set 5 : Undid more changes relative to original code. #

Total comments: 10

Patch Set 6 : Addressed review feedback from sergiyb. #

Patch Set 7 : Rebased again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6054 lines, -21225 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 2 3 4 5 6 1 chunk +0 lines, -49 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 2 3 4 5 6 5 chunks +3 lines, -185 lines 0 comments Download
M scripts/slave/recipe_modules/gpu/api.py View 1 2 3 4 5 6 2 chunks +21 lines, -24 lines 0 comments Download
M scripts/slave/recipe_modules/gpu/common.py View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/gpu/test_api.py View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/api.py View 1 2 3 4 5 6 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipe_modules/swarming/api.py View 1 2 3 4 5 6 2 chunks +0 lines, -86 lines 0 comments Download
M scripts/slave/recipe_modules/test_utils/test_api.py View 1 2 3 4 5 6 1 chunk +0 lines, -35 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 1 2 3 4 5 6 6 chunks +13 lines, -47 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_runs_only_angle_unittests.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json View 1 2 3 4 5 6 38 chunks +49 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json View 1 2 3 4 5 6 3 chunks +4 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json View 1 2 3 4 5 6 5 chunks +8 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json View 1 2 3 4 5 6 5 chunks +8 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deapply_fn.json View 1 2 3 4 5 6 39 chunks +51 lines, -86 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json View 1 2 3 4 5 6 5 chunks +8 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/dont_analyze_for_non_src_project.json View 1 2 3 4 5 6 3 chunks +4 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_dbg.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_dbg_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_dbg_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_rel.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_rel_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_rel_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_ng.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_ng_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_ng_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_dbg.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_dbg_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_dbg_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_rel.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_rel_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_rel_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_dbg.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_dbg_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_dbg_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_rel.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_rel_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_rel_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel_fail.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel_pass.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_linux_angle_dbg_ng.json View 1 2 3 4 5 6 38 chunks +49 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_linux_angle_dbg_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_linux_angle_rel_ng.json View 1 2 3 4 5 6 38 chunks +49 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_linux_angle_rel_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_mac_angle_dbg_ng.json View 1 2 3 4 5 6 70 chunks +88 lines, -153 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_mac_angle_dbg_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_mac_angle_rel_ng.json View 1 2 3 4 5 6 70 chunks +88 lines, -153 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_mac_angle_rel_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_win_angle_dbg_ng.json View 1 2 3 4 5 6 82 chunks +104 lines, -181 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_win_angle_dbg_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_win_angle_rel_ng.json View 1 2 3 4 5 6 82 chunks +104 lines, -181 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_win_angle_rel_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_win_angle_x64_dbg_ng.json View 1 2 3 4 5 6 82 chunks +104 lines, -181 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_win_angle_x64_dbg_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_win_angle_x64_rel_ng.json View 1 2 3 4 5 6 82 chunks +104 lines, -181 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_win_angle_x64_rel_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_blink_oilpan_rel.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json View 1 2 3 4 5 6 38 chunks +49 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_ng.json View 1 2 3 4 5 6 70 chunks +88 lines, -153 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_rel_ng.json View 1 2 3 4 5 6 73 chunks +88 lines, -153 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_rel_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng.json View 1 2 3 4 5 6 73 chunks +88 lines, -153 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_optional_gpu_tests_rel.json View 1 2 3 4 5 6 18 chunks +23 lines, -40 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_optional_gpu_tests_rel_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gpu_tests.json View 1 2 3 4 5 6 81 chunks +98 lines, -164 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/invalid_results.json View 1 2 3 4 5 6 40 chunks +53 lines, -88 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/non_cq_blink_tryjob.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json View 1 2 3 4 5 6 73 chunks +88 lines, -153 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json View 1 2 3 4 5 6 38 chunks +49 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json View 1 2 3 4 5 6 38 chunks +49 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json View 1 2 3 4 5 6 38 chunks +49 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_paths.json View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json View 1 2 3 4 5 6 38 chunks +49 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_time_out_is_handled_correctly.json View 1 2 3 4 5 6 71 chunks +89 lines, -150 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json View 1 2 3 4 5 6 38 chunks +49 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_harness_failure.json View 1 2 3 4 5 6 45 chunks +57 lines, -406 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_results.json View 1 2 3 4 5 6 1 chunk +0 lines, -3988 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_summary.json View 1 2 3 4 5 6 1 chunk +0 lines, -4009 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_swarming_error.json View 1 2 3 4 5 6 75 chunks +92 lines, -153 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json View 1 2 3 4 5 6 77 chunks +96 lines, -481 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json View 1 2 3 4 5 6 3 chunks +4 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/webkit_tests_interrupted.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/webkit_tests_unexpected_error.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/killall_gnome_keyring_failure.json View 1 2 3 4 5 6 3 chunks +4 lines, -7 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug.json View 1 2 3 4 5 6 7 chunks +124 lines, -304 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_blink.json View 1 2 3 4 5 6 7 chunks +124 lines, -304 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_tryserver.json View 1 2 3 4 5 6 10 chunks +128 lines, -308 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release.json View 1 2 3 4 5 6 7 chunks +124 lines, -304 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_blink.json View 1 2 3 4 5 6 7 chunks +124 lines, -304 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_fyi.json View 1 2 3 4 5 6 3 chunks +4 lines, -7 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_tryserver.json View 1 2 3 4 5 6 10 chunks +128 lines, -308 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_blink.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_tryserver.json View 1 2 3 4 5 6 10 chunks +128 lines, -268 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_blink.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_git.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_skip_checkout.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_skip_compile.json View 1 2 3 4 5 6 9 chunks +130 lines, -270 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json View 1 2 3 4 5 6 10 chunks +128 lines, -268 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver_blink.json View 1 2 3 4 5 6 10 chunks +128 lines, -268 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_blink.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_tryserver.json View 1 2 3 4 5 6 10 chunks +128 lines, -268 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_blink.json View 1 2 3 4 5 6 7 chunks +124 lines, -264 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_fyi.json View 1 2 3 4 5 6 3 chunks +4 lines, -7 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json View 1 2 3 4 5 6 10 chunks +128 lines, -268 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_nothing.json View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_only_angle_unittests.json View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/compile_fail_is_critical_on_main.json View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/compile_with_patch_fail.json View 1 2 3 4 5 6 5 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/compile_without_patch_fail.json View 1 2 3 4 5 6 5 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/linux_debug.json View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/linux_release.json View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_debug.json View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_release.json View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_debug.json View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release.json View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release_tot_angle.json View 1 2 3 4 5 6 3 chunks +4 lines, -7 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.py View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/failures_keeps_going.json View 1 2 3 4 5 6 9 chunks +130 lines, -320 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/linux_debug.json View 1 2 3 4 5 6 8 chunks +128 lines, -318 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/linux_release.json View 1 2 3 4 5 6 9 chunks +130 lines, -320 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/linux_release_deqp.json View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/mac_debug.json View 1 2 3 4 5 6 8 chunks +128 lines, -278 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/mac_release.json View 1 2 3 4 5 6 9 chunks +130 lines, -280 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/telemetry_gpu_test_harness_failure.json View 1 2 3 4 5 6 9 chunks +127 lines, -320 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/win_debug.json View 1 2 3 4 5 6 8 chunks +128 lines, -278 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/win_release.json View 1 2 3 4 5 6 9 chunks +130 lines, -280 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/win_release_deqp.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Ken Russell (switch to Gerrit)
phajdan.jr, sergiyb: could you please review all of the Python changes, in particular in chromium_tests/ ...
5 years ago (2015-12-08 06:41:50 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years ago (2015-12-08 07:31:41 UTC) #3
Sergiy Byelozyorov
Nice cleanup, thanks a lot! LGTM https://codereview.chromium.org/1506073002/diff/40001/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://codereview.chromium.org/1506073002/diff/40001/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode1548 scripts/slave/recipe_modules/chromium_tests/steps.py:1548: # TODO(kbr): crbug.com/553925 ...
5 years ago (2015-12-08 10:09:42 UTC) #4
bajones
recipe_modules/gpu and recipes/gpu LGTM
5 years ago (2015-12-08 18:32:42 UTC) #5
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1506073002/diff/40001/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://codereview.chromium.org/1506073002/diff/40001/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode1548 scripts/slave/recipe_modules/chromium_tests/steps.py:1548: # TODO(kbr): crbug.com/553925 - this line is intermittently On ...
5 years ago (2015-12-08 19:35:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506073002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506073002/60001
5 years ago (2015-12-09 19:08:13 UTC) #9
commit-bot: I haz the power
Committed patchset #7 (id:60001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=297922
5 years ago (2015-12-09 19:16:36 UTC) #11
Ken Russell (switch to Gerrit)
5 years ago (2015-12-09 21:07:30 UTC) #12
Message was sent while issue was closed. 
On 2015/12/09 19:16:36, commit-bot: I haz the power wrote:
> Committed patchset #7 (id:60001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=297922

Reverted in https://codereview.chromium.org/1512093002 because this broke
screenshot_sync on multiple trybots. See crbug.com/561863.

Powered by Google App Engine
This is Rietveld 408576698