third_party/WebKit/LayoutTests/hittesting/image-with-clip-path.html - Issue 1506053003: Include clip-path and border radius when hit testing boxes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/hittesting/image-with-clip-path.html

Issue 1506053003: Include clip-path and border radius when hit testing boxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup tests to use js-test.js Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/hittesting/image-with-border-radius-expected.txt ('k') | third_party/WebKit/LayoutTests/hittesting/image-with-clip-path-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="../resources/js-test.js"></script>

	3 <script>

	4 function test() {

	5 // At bottom-left corner, outside the clip-path region.

	6 shouldNotBe("document.elementFromPoint(25, 75).id", "'image'");

	7

	8 // At top-right corner, inside the clip-path region.

	9 shouldBe("document.elementFromPoint(75, 25).id", "'image'");

	10 }

	11 </script>

	12 <style>

	13 #image {

	14 -webkit-clip-path: url(#clipPathTopLeft);

	15 clip-path: url(#clipPathTopLeft);
	Rick Byers 2015/12/11 16:02:51 So this test covers the 'ClipPathOperation:REFEREN So this test covers the 'ClipPathOperation:REFERENCE' case in the code, but the 'ClipPathOperation:SHAPE' case is still untested, right? Perhaps it would be worth adding another case here for that too? pdr. 2015/12/11 18:09:23 Good idea, done in the latest patch. Show quoted text On 2015/12/11 at 16:02:51, Rick Byers wrote: > So this test covers the 'ClipPathOperation:REFERENCE' case in the code, but the 'ClipPathOperation:SHAPE' case is still untested, right? Perhaps it would be worth adding another case here for that too? Good idea, done in the latest patch.
	16 width: 100px;

	17 height: 100px;

	18 position: absolute;

	19 top: 0;

	20 left: 0;

	21 }

	22 #image:hover {

	23 background: green;

	24 }

	25 </style>

	26 <body onload="test()">

	27 <p>Image hit testing should not include clipped-out regions.</p>

	28 <svg width="100" height="0">

	29 <defs>

	30 <clipPath id="clipPathTopLeft">

	31 <path id="path" d="M 0 0 L 100 100 L 100 0Z" />

	32 </clipPath>

	33 </defs>

	34 </svg>

	35 <img id="image" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFC AYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJgg g==">

	36 <div id="console"></div>

	37 </body>

OLD	NEW