[NOT LANDED] Revert of cc: Split ThreadProxy into ProxyMain and ProxyImpl

Revert of cc: Split ThreadProxy into ProxyMain and ProxyImpl (patchset #24 id:460001 of https://codereview.chromium.org/1417053005/ )

Reason for revert:
Quite likely causing substantial flakiness in cc_unittests on 'Win7 Tests (dbg)(1)'.

LayerTreeHostCopyRequestCompletionCausesCommit.RunMultiThread_DirectRenderer (run #1):
[ RUN      ] LayerTreeHostCopyRequestCompletionCausesCommit.RunMultiThread_DirectRenderer
c:uild\slave\win_builder__dbg_uild\src\cc	rees\layer_tree_host_unittest_copyrequest.cc(222): error: Value of: callback_count_
  Actual: 0
Expected: 1
[  FAILED  ] LayerTreeHostCopyRequestCompletionCausesCommit.RunMultiThread_DirectRenderer (23 ms)

See: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Original issue's description:
> cc: Split ThreadProxy into ProxyMain and ProxyImpl
> 
> This is the final patch that splits ThreadProxy into ProxyMain and
> ProxyImpl routing all inter-proxy communication using ChannelMain
> and ChannelImpl.
> 
> ThreadProxy currently implements the logic for glueing together the
> Scheduler, LayerTreeHostImpl and the LayerTreeHost and separating these
> components across the main and impl thread boundary. This patch isolates
> the logic for this glue code in ThreadProxy exclusive to each thread to
> ProxyMain and ProxyImpl. This will allow us to abstract the medium the
> 2 sides use to communicate with each other so these components can be
> run across a thread/process/network boundary.
> 
> ThreadedChannel implements the in-process threaded case.
> 
> BUG=527200
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/0a226af5cb4c5ca5b3bac3e3d857601cc356dc33
> Cr-Commit-Position: refs/heads/master@{#364034}

TBR=wez@chromium.org,brianderson@chromium.org,danakj@chromium.org,dtrainor@chromium.org,enne@chromium.org,vmpstr@chromium.org,nednguyen@google.com,sullivan@chromium.org,skyostil@google.com,khushalsagar@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=527200

[engedy, 2015-12-09 13:33:04]

Created Revert of cc: Split ThreadProxy into ProxyMain and ProxyImpl

[engedy, 2015-12-09 13:33:09]

The CQ bit was unchecked by engedy@chromium.org

[engedy, 2015-12-09 13:36:32]

Please ignore this, revert NOT landed, it was just coincidence. Those tests
starting flaking long before this CL was landed.

[engedy, 2015-12-09 13:36:58]

Description was changed from

==========
Revert of cc: Split ThreadProxy into ProxyMain and ProxyImpl (patchset #24
id:460001 of https://codereview.chromium.org/1417053005/ )

Reason for revert:
Quite likely causing substantial flakiness in cc_unittests on 'Win7 Tests
(dbg)(1)'.

LayerTreeHostCopyRequestCompletionCausesCommit.RunMultiThread_DirectRenderer
(run #1):
[ RUN      ]
LayerTreeHostCopyRequestCompletionCausesCommit.RunMultiThread_DirectRenderer
c:uild\slave\win_builder__dbg_uild\src\cc	rees\layer_tree_host_unittest_copyrequest.cc(222):
error: Value of: callback_count_
  Actual: 0
Expected: 1
[  FAILED  ]
LayerTreeHostCopyRequestCompletionCausesCommit.RunMultiThread_DirectRenderer (23
ms)

See:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...

Original issue's description:
> cc: Split ThreadProxy into ProxyMain and ProxyImpl
> 
> This is the final patch that splits ThreadProxy into ProxyMain and
> ProxyImpl routing all inter-proxy communication using ChannelMain
> and ChannelImpl.
> 
> ThreadProxy currently implements the logic for glueing together the
> Scheduler, LayerTreeHostImpl and the LayerTreeHost and separating these
> components across the main and impl thread boundary. This patch isolates
> the logic for this glue code in ThreadProxy exclusive to each thread to
> ProxyMain and ProxyImpl. This will allow us to abstract the medium the
> 2 sides use to communicate with each other so these components can be
> run across a thread/process/network boundary.
> 
> ThreadedChannel implements the in-process threaded case.
> 
> BUG=527200
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/0a226af5cb4c5ca5b3bac3e3d857601cc356dc33
> Cr-Commit-Position: refs/heads/master@{#364034}

TBR=wez@chromium.org,brianderson@chromium.org,danakj@chromium.org,dtrainor@ch...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=527200
==========

to

==========
Revert of cc: Split ThreadProxy into ProxyMain and ProxyImpl (patchset #24
id:460001 of https://codereview.chromium.org/1417053005/ )

Reason for revert:
Quite likely causing substantial flakiness in cc_unittests on 'Win7 Tests
(dbg)(1)'.

LayerTreeHostCopyRequestCompletionCausesCommit.RunMultiThread_DirectRenderer
(run #1):
[ RUN      ]
LayerTreeHostCopyRequestCompletionCausesCommit.RunMultiThread_DirectRenderer
c:uild\slave\win_builder__dbg_uild\src\cc	rees\layer_tree_host_unittest_copyrequest.cc(222):
error: Value of: callback_count_
  Actual: 0
Expected: 1
[  FAILED  ]
LayerTreeHostCopyRequestCompletionCausesCommit.RunMultiThread_DirectRenderer (23
ms)

See:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...

Original issue's description:
> cc: Split ThreadProxy into ProxyMain and ProxyImpl
> 
> This is the final patch that splits ThreadProxy into ProxyMain and
> ProxyImpl routing all inter-proxy communication using ChannelMain
> and ChannelImpl.
> 
> ThreadProxy currently implements the logic for glueing together the
> Scheduler, LayerTreeHostImpl and the LayerTreeHost and separating these
> components across the main and impl thread boundary. This patch isolates
> the logic for this glue code in ThreadProxy exclusive to each thread to
> ProxyMain and ProxyImpl. This will allow us to abstract the medium the
> 2 sides use to communicate with each other so these components can be
> run across a thread/process/network boundary.
> 
> ThreadedChannel implements the in-process threaded case.
> 
> BUG=527200
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/0a226af5cb4c5ca5b3bac3e3d857601cc356dc33
> Cr-Commit-Position: refs/heads/master@{#364034}

TBR=wez@chromium.org,brianderson@chromium.org,danakj@chromium.org,dtrainor@ch...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=527200
==========

[engedy, 2015-12-09 15:26:13]

On 2015/12/09 13:36:32, engedy wrote:
> Please ignore this, revert NOT landed, it was just coincidence. Those tests
> starting flaking long before this CL was landed.

Instead, I have filed crbug.com/568100 to track the issue.