Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Issue 1506023005: New Mojom parser: Fix up error messages for lexing errors. (Closed)

Created:
5 years ago by rudominer
Modified:
5 years ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

New Mojom parser: Fix up error messages for lexing errors. BUG=#461 - Test and improve parser error messages for when the lexer returns ErrorIllegalChar, ErrorUnterminatedStringLiteral and ErrorUnterminatedComment - Get rid of ErrorUnknown because it was not used. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fe1bf5b742b2d9341d1d02972909a3ed8a1e7328

Patch Set 1 #

Patch Set 2 : Adds new sha1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -25 lines) Patch
M mojo/public/tools/bindings/mojom_parser/bin/linux64/mojom_parser.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/lexer/tokens.go View 4 chunks +13 lines, -9 lines 0 comments Download
M mojom/mojom_parser/parser/parser_test.go View 1 chunk +182 lines, -0 lines 0 comments Download
M mojom/mojom_parser/parser/parsing.go View 10 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
rudominer
Hi Alex, ptal.
5 years ago (2015-12-08 22:59:16 UTC) #7
azani
lgtm
5 years ago (2015-12-08 23:06:26 UTC) #8
rudominer
5 years ago (2015-12-09 06:48:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
fe1bf5b742b2d9341d1d02972909a3ed8a1e7328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698