Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1506003002: Handle property accesses in generic method invocation (Closed)

Created:
5 years ago by Leaf
Modified:
5 years ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle property accesses in generic method invocation BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/67306ae65518a68535fab4f3e557f7dfc43a2093

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Leaf
5 years ago (2015-12-07 23:07:05 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/1506003002/diff/1/pkg/analyzer/test/generated/resolver_test.dart File pkg/analyzer/test/generated/resolver_test.dart (right): https://codereview.chromium.org/1506003002/diff/1/pkg/analyzer/test/generated/resolver_test.dart#newcode13163 pkg/analyzer/test/generated/resolver_test.dart:13163: void g(F f3) { test a local variable ...
5 years ago (2015-12-07 23:15:13 UTC) #3
Leaf
https://codereview.chromium.org/1506003002/diff/1/pkg/analyzer/test/generated/resolver_test.dart File pkg/analyzer/test/generated/resolver_test.dart (right): https://codereview.chromium.org/1506003002/diff/1/pkg/analyzer/test/generated/resolver_test.dart#newcode13163 pkg/analyzer/test/generated/resolver_test.dart:13163: void g(F f3) { On 2015/12/07 23:15:13, John Messerly ...
5 years ago (2015-12-08 00:00:54 UTC) #4
Leaf
5 years ago (2015-12-08 00:01:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
67306ae65518a68535fab4f3e557f7dfc43a2093 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698