Consistently start (almost) all AstPrinter::VisitFoo functions with IndentedScope.

Consistently start (almost) all AstPrinter::VisitFoo functions with IndentedScope.

This makes IndentedScope the single point where we can print additional info in
the future, like e.g. AST IDs (at least when the TODOs are fixed). Minor other
cleanups.

R=mvstanton@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=14592

[mvstanton, 2013-05-08 13:11:03]

One question, but I like the IndentedScope. lgtm.

https://chromiumcodereview.appspot.com/15060005/diff/1/src/prettyprinter.cc
File src/prettyprinter.cc (right):

https://chromiumcodereview.appspot.com/15060005/diff/1/src/prettyprinter.cc#n...
src/prettyprinter.cc:773: // TODO(svenpanne) Start with IndentedScope.
Actually can you fold the fix in here instead of the TODO?

https://chromiumcodereview.appspot.com/15060005/diff/1/src/prettyprinter.cc#n...
src/prettyprinter.cc:781: // TODO(svenpanne) Start with IndentedScope.
And here.

[Sven Panne, 2013-05-08 13:23:56]

The TODOs were intentionally there, more cleanup/refactorings are needed before
we could remove them. Landing...

https://chromiumcodereview.appspot.com/15060005/diff/1/src/prettyprinter.cc
File src/prettyprinter.cc (right):

https://chromiumcodereview.appspot.com/15060005/diff/1/src/prettyprinter.cc#n...
src/prettyprinter.cc:773: // TODO(svenpanne) Start with IndentedScope.
On 2013/05/08 13:11:03, mvstanton wrote:
> Actually can you fold the fix in here instead of the TODO?

Actually no, or at least not easily: As usual, we mix up different things, in
this instance converting things to a string *and* printing them. If they were
separated cleanly, it would be easy.

[Sven Panne, 2013-05-08 13:24:51]

Committed patchset #1 manually as r14592 (presubmit successful).