Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1505993007: Another undefined shift caught by -fsanitize=shift. (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Another undefined shift caught by -fsanitize=shift. left was -16 I didn't see any warning about fTop, but seems simplest to fix that too. BUG=skia: Committed: https://skia.googlesource.com/skia/+/cefb4597624ef098e5d89a9a961d5b5159fd4214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/core/SkScan_AntiPath.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mtklein_C
5 years ago (2015-12-09 21:05:18 UTC) #2
caryclark
lgtm
5 years ago (2015-12-09 21:07:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505993007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505993007/1
5 years ago (2015-12-09 21:17:41 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-09 21:33:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cefb4597624ef098e5d89a9a961d5b5159fd4214

Powered by Google App Engine
This is Rietveld 408576698