Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1505983002: EDK: Remove platform_handle_utils*. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Remove platform_handle_utils*. Instead, give PlatformHandle and ScopedPlatformHandle Duplicate() methods. (It's a little odd, dependency-wise anyway, that PlatformHandle::Duplicate() returns a ScopedPlatformHandle, but it makes sense logically -- you may have a PlatformHandle, which you don't own, but you'll own the result of Duplicate() -- and is obviously safer.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a76b9b452baabfaab3de4c26d34d7d28c78fd94f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -61 lines) Patch
M mojo/edk/embedder/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/edk/embedder/platform_handle_utils.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/edk/embedder/platform_handle_utils_posix.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/platform/platform_handle.h View 1 chunk +11 lines, -1 line 0 comments Download
M mojo/edk/platform/platform_handle.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M mojo/edk/platform/scoped_platform_handle.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-12-07 22:24:57 UTC) #1
vardhan
lgtm
5 years ago (2015-12-07 23:23:53 UTC) #2
viettrungluu
5 years ago (2015-12-07 23:43:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a76b9b452baabfaab3de4c26d34d7d28c78fd94f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698