Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 1505963002: Revert of Remove migrateNetworkPredictionPreferences(). (Closed)

Created:
5 years ago by Bence
Modified:
5 years ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove migrateNetworkPredictionPreferences(). (patchset #3 id:40001 of https://codereview.chromium.org/1323993002/ ) Reason for revert: Causing lots of crashes with ClassCastException. Original issue's description: > Remove migrateNetworkPredictionPreferences(). > > Remove predictive network action preference migration code on Android after one > year. This includes migrateNetworkPredictionPreferences(), string constants for > preferences, and JNI accessors. > > BUG=526773 > > Committed: https://crrev.com/2eab6589a52b9773f6c0294b69beef35ed4c7bf0 > Cr-Commit-Position: refs/heads/master@{#346898} BUG=526773

Patch Set 1 #

Messages

Total messages: 4 (2 generated)
Bence
Created Revert of Remove migrateNetworkPredictionPreferences().
5 years ago (2015-12-07 21:46:30 UTC) #1
Bence
5 years ago (2015-12-07 21:54:54 UTC) #4
Message was sent while issue was closed.
Closing this patch because we do not expect a clean revert to work.  JNI does
not take jobject anymore, they take JavaParamRef, among other reasons.

Powered by Google App Engine
This is Rietveld 408576698