Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1505953007: Silence libjpeg warnings in SkImageDecoder (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@nonOpaqueJpeg
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Silence libjpeg warnings in SkImageDecoder We just did the same for libpng (see crrev.com/1512043002), so we might as well do this here. SkImageDecoder is deprecated, and SkCodec already has a way to turn off its messages. BUG=skia:1649 Committed: https://skia.googlesource.com/skia/+/645f6d9e399f42b1ff5fec9be7368bac2bab308f

Patch Set 1 #

Patch Set 2 : Remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/images/SkImageDecoder_libjpeg.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
scroggo
5 years ago (2015-12-09 21:22:13 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1517523003 Patch 1). Please resolve the dependency and ...
5 years ago (2015-12-09 21:22:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505953007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505953007/20001
5 years ago (2015-12-09 21:23:18 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years ago (2015-12-09 21:23:18 UTC) #8
msarett
lgtm
5 years ago (2015-12-09 21:23:29 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 21:40:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/645f6d9e399f42b1ff5fec9be7368bac2bab308f

Powered by Google App Engine
This is Rietveld 408576698