Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: sync/internal_api/syncapi_server_connection_manager_unittest.cc

Issue 1505953002: [Sync] Remove ScopedServerStatusWatcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change format of deprecated names. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/syncer_proto_util_unittest.cc ('k') | sync/protocol/proto_enum_conversions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/syncapi_server_connection_manager_unittest.cc
diff --git a/sync/internal_api/syncapi_server_connection_manager_unittest.cc b/sync/internal_api/syncapi_server_connection_manager_unittest.cc
index e438ac181fc06e9c8a17f9a68b6cd76841d8e1da..208b3a2d763c118221a77d1a20de9b6989bd1255 100644
--- a/sync/internal_api/syncapi_server_connection_manager_unittest.cc
+++ b/sync/internal_api/syncapi_server_connection_manager_unittest.cc
@@ -72,10 +72,8 @@ TEST(SyncAPIServerConnectionManagerTest, VeryEarlyAbortPost) {
"server", 0, true, new BlockingHttpPostFactory(), &signal);
ServerConnectionManager::PostBufferParams params;
- ScopedServerStatusWatcher watcher(&server, &params.response);
- bool result = server.PostBufferToPath(
- &params, "/testpath", "testauth", &watcher);
+ bool result = server.PostBufferToPath(&params, "/testpath", "testauth");
EXPECT_FALSE(result);
EXPECT_EQ(HttpResponse::CONNECTION_UNAVAILABLE,
@@ -89,11 +87,9 @@ TEST(SyncAPIServerConnectionManagerTest, EarlyAbortPost) {
"server", 0, true, new BlockingHttpPostFactory(), &signal);
ServerConnectionManager::PostBufferParams params;
- ScopedServerStatusWatcher watcher(&server, &params.response);
signal.Signal();
- bool result = server.PostBufferToPath(
- &params, "/testpath", "testauth", &watcher);
+ bool result = server.PostBufferToPath(&params, "/testpath", "testauth");
EXPECT_FALSE(result);
EXPECT_EQ(HttpResponse::CONNECTION_UNAVAILABLE,
@@ -107,7 +103,6 @@ TEST(SyncAPIServerConnectionManagerTest, AbortPost) {
"server", 0, true, new BlockingHttpPostFactory(), &signal);
ServerConnectionManager::PostBufferParams params;
- ScopedServerStatusWatcher watcher(&server, &params.response);
base::Thread abort_thread("Test_AbortThread");
ASSERT_TRUE(abort_thread.Start());
@@ -117,8 +112,7 @@ TEST(SyncAPIServerConnectionManagerTest, AbortPost) {
base::Unretained(&signal)),
TestTimeouts::tiny_timeout());
- bool result = server.PostBufferToPath(
- &params, "/testpath", "testauth", &watcher);
+ bool result = server.PostBufferToPath(&params, "/testpath", "testauth");
EXPECT_FALSE(result);
EXPECT_EQ(HttpResponse::CONNECTION_UNAVAILABLE,
« no previous file with comments | « sync/engine/syncer_proto_util_unittest.cc ('k') | sync/protocol/proto_enum_conversions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698