Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1505933003: Labeled WebGraphicsContext3D context. (Closed)

Created:
5 years ago by David Yen
Modified:
5 years ago
Reviewers:
no sievers
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Labeled WebGraphicsContext3D context. R=sievers@chromium.org BUG=242999 Committed: https://crrev.com/7dbe2baa5e4075df1ba76c9391ad14049f1983d4 Cr-Commit-Position: refs/heads/master@{#363959}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +2 lines, -0 lines 2 comments Download
M gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
David Yen
5 years ago (2015-12-07 23:34:07 UTC) #1
David Yen
5 years ago (2015-12-07 23:34:57 UTC) #4
David Yen
ping, build errors are unrelated and caused by this: https://code.google.com/p/chromium/issues/detail?id=531579
5 years ago (2015-12-08 22:15:55 UTC) #5
no sievers
lgtm https://codereview.chromium.org/1505933003/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc (right): https://codereview.chromium.org/1505933003/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc#newcode157 content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc:157: real_gl_->TraceBeginCHROMIUM("WebGraphicsContext3D", and this doesn't need 'end'?
5 years ago (2015-12-08 22:17:42 UTC) #6
David Yen
https://codereview.chromium.org/1505933003/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc (right): https://codereview.chromium.org/1505933003/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc#newcode157 content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc:157: real_gl_->TraceBeginCHROMIUM("WebGraphicsContext3D", On 2015/12/08 22:17:42, sievers wrote: > and this ...
5 years ago (2015-12-08 22:20:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505933003/1
5 years ago (2015-12-08 23:54:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 03:07:32 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-09 03:08:16 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7dbe2baa5e4075df1ba76c9391ad14049f1983d4
Cr-Commit-Position: refs/heads/master@{#363959}

Powered by Google App Engine
This is Rietveld 408576698