Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rearrange field_trial.. again to facilitate command line testing Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java
index b5ba3c0c1cdbdfc1b276a382eb4559e2ae1e7856..63c4f389c6513415a6bae2494005e0086ccf8501 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java
@@ -44,4 +44,18 @@ public interface Toolbar {
* @return Whether a dirty check for invalidation makes sense at this time.
*/
boolean isReadyForTextureCapture();
+
+ /**
+ * Show the update badge on the app menu button. Will have no effect if there is no app menu
+ * button for the current Activity.
+ */
+ void showAppMenuUpdateBadge();
+
+ /**
+ * Remove the update badge on the app menu button. Initially the badge is invisible so that it
+ * gets measured and the tab switcher animation looks correct when the badge is first shown. If
+ * the badge will never be shown, this method should be called to change the visibility to
+ * gone to avoid unnecessary layout work.
+ */
+ void removeAppMenuUpdateBadge();
}

Powered by Google App Engine
This is Rietveld 408576698