Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rearrange field_trial.. again to facilitate command line testing Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
index 360e2686cbd53ab8fb3c800936eb9f08c7d9e374..1d6755ae4df9e52b7db87639dc33b8828e970c8e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
@@ -908,6 +908,21 @@ public final class PrefServiceBridge {
return nativeHasSetMetricsReporting();
}
+ /**
+ * @param clicked Whether the update menu item was clicked. The preference is stored to
+ * facilitate logging whether Chrome was updated after a click on the menu item.
+ */
+ public void setClickedUpdateMenuItem(boolean clicked) {
+ nativeSetClickedUpdateMenuItem(clicked);
+ }
+
+ /**
+ * @return Whether the update menu item was clicked.
+ */
+ public boolean getClickedUpdateMenuItem() {
+ return nativeGetClickedUpdateMenuItem();
+ }
+
private native boolean nativeGetAcceptCookiesEnabled();
private native boolean nativeGetAcceptCookiesManaged();
private native boolean nativeGetBlockThirdPartyCookiesEnabled();
@@ -1000,4 +1015,6 @@ public final class PrefServiceBridge {
private native boolean nativeGetMetricsReportingEnabled();
private native void nativeSetMetricsReportingEnabled(boolean enabled);
private native boolean nativeHasSetMetricsReporting();
+ private native void nativeSetClickedUpdateMenuItem(boolean clicked);
+ private native boolean nativeGetClickedUpdateMenuItem();
}

Powered by Google App Engine
This is Rietveld 408576698