chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 1505913003: Add update menu item and app menu icon badge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rearrange field_trial.. again to facilitate command line testing Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index 8520527553125730a8446df46b8534de70c25ce9..1fb2909f5773b503e775d95e3d8d4530899f9c20 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -15,6 +15,7 @@ import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.bookmark.BookmarksBridge;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

+import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;

import org.chromium.chrome.browser.preferences.ManagedPreferencesUtils;

import org.chromium.chrome.browser.preferences.PrefServiceBridge;

import org.chromium.chrome.browser.share.ShareHelper;

@@ -110,6 +111,9 @@ public class AppMenuPropertiesDelegate {

}

+ menu.findItem(R.id.update_menu_id).setVisible(

+ UpdateMenuItemHelper.getInstance().shouldShowMenuItem(mActivity));

// Hide "Recent tabs" in incognito mode or when sync can't be enabled.

MenuItem recentTabsMenuItem = menu.findItem(R.id.recent_tabs_menu_id);

recentTabsMenuItem.setVisible(!isIncognito && FeatureUtilities.canAllowSync(mActivity));