Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3721)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rearrange field_trial.. again to facilitate command line testing Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
index 4d66d32c2f3235dffaec9b9e323d54ec79c12912..3a9e36f4e029804bae1324333f58398232c24808 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
@@ -32,8 +32,8 @@ import android.widget.PopupWindow.OnDismissListener;
import org.chromium.base.AnimationFrameTimeHistogram;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.SysUtils;
-import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;
import java.util.ArrayList;
import java.util.List;
@@ -293,6 +293,9 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {
*/
void onItemClick(MenuItem menuItem) {
if (menuItem.isEnabled()) {
+ if (menuItem.getItemId() == R.id.update_menu_id) {
+ UpdateMenuItemHelper.getInstance().setMenuItemClicked();
+ }
dismiss();
mHandler.onOptionsItemSelected(menuItem);
}
@@ -352,8 +355,7 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {
/**
* @return The menu instance inside of this class.
*/
- @VisibleForTesting
- public Menu getMenuForTest() {
+ public Menu getMenu() {
return mMenu;
}

Powered by Google App Engine
This is Rietveld 408576698