Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/menu_item.xml

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rearrange field_trial.. again to facilitate command line testing Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/location_bar.xml ('k') | chrome/android/java/res/layout/toolbar.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/menu_item.xml
diff --git a/chrome/android/java/res/layout/menu_item.xml b/chrome/android/java/res/layout/menu_item.xml
index 668c7e5531b7b0facf35a1e282cd8a34d39cdd29..3fe96c92acd0223d6051da49e5df5e9fd5dc105f 100644
--- a/chrome/android/java/res/layout/menu_item.xml
+++ b/chrome/android/java/res/layout/menu_item.xml
@@ -6,11 +6,9 @@
-->
<!-- Layout for each item in the menu popup -->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ style="@style/AppMenuItem"
android:layout_width="match_parent"
- android:layout_height="?android:attr/listPreferredItemHeightSmall"
- android:paddingStart="16dp"
- android:paddingEnd="16dp"
- android:background="?attr/listChoiceBackgroundIndicator">
+ android:layout_height="?android:attr/listPreferredItemHeightSmall" >
<TextView
android:id="@+id/menu_item_text"
android:textAppearance="?android:attr/textAppearanceLargePopupMenu"
@@ -21,8 +19,7 @@
android:gravity="center_vertical"
android:singleLine="true"
android:paddingEnd="9dp" />
- <view
- class="org.chromium.chrome.browser.appmenu.AppMenuItemIcon"
+ <org.chromium.chrome.browser.appmenu.AppMenuItemIcon
android:id="@+id/menu_item_icon"
android:layout_weight="0"
android:layout_width="wrap_content"
« no previous file with comments | « chrome/android/java/res/layout/location_bar.xml ('k') | chrome/android/java/res/layout/toolbar.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698