Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add code create 1dp transparent border in LocatoinBarPhone Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
index 4e73d9bca9b2689be8fb2098193d901b837249e9..b649090390ea6806eac8d90c17895a507f871a0a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
@@ -85,12 +85,12 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
mBookmarkButton = (TintedImageButton) findViewById(R.id.bookmark_button);
mMenuButton = (TintedImageButton) findViewById(R.id.menu_button);
- mMenuButton.setVisibility(
+ mMenuButtonWrapper.setVisibility(
shouldShowMenuButton() ? View.VISIBLE : View.GONE);
if (mAccessibilitySwitcherButton.getVisibility() == View.GONE
- && mMenuButton.getVisibility() == View.GONE) {
- ApiCompatibilityUtils.setPaddingRelative((View) mMenuButton.getParent(), 0, 0,
+ && mMenuButtonWrapper.getVisibility() == View.GONE) {
+ ApiCompatibilityUtils.setPaddingRelative((View) mMenuButtonWrapper.getParent(), 0, 0,
getResources().getDimensionPixelSize(R.dimen.tablet_toolbar_end_padding), 0);
}
}
@@ -405,4 +405,8 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
return mLocationBar;
}
+ @Override
+ public void showAppMenuUpdateBadge() {
+ mMenuBadge.setVisibility(View.VISIBLE);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698