chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java - Issue 1505913003: Add update menu item and app menu icon badge

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add code create 1dp transparent border in LocatoinBarPhone Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

index 2f8c437919dfd1a2752621c5a376e618a5053c2b..3122a7054c5709b5a5dc1a9e3147ee992306225e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

@@ -41,6 +41,7 @@ import org.chromium.chrome.browser.firstrun.FirstRunStatus;

import org.chromium.chrome.browser.metrics.StartupMetrics;

import org.chromium.chrome.browser.metrics.UmaUtils;

import org.chromium.chrome.browser.ntp.NewTabPage;

+import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;

import org.chromium.chrome.browser.preferences.ChromePreferenceManager;

import org.chromium.chrome.browser.preferences.PrefServiceBridge;

import org.chromium.chrome.browser.preferences.datareduction.DataReductionPreferences;

@@ -709,6 +710,10 @@ public class DocumentActivity extends ChromeActivity {

DataReductionPreferences.launchDataReductionSSLInfoBar(

DocumentActivity.this, mDocumentTab.getWebContents());

}

+ if (UpdateMenuItemHelper.getInstance().shouldShowToolbarBadge(this)) {

+ getToolbarManager().getToolbar().showAppMenuUpdateBadge();

+ }

gone 2015/12/08 22:24:23 Is this bit necessary? DocumentActivity is a Chro

Theresa 2015/12/10 03:53:18 I added this because I was seeing the first Docume

}

private void resetIcon() {