Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rearrange field_trial.. again to facilitate command line testing Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/menu/main_menu.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 </style> 458 </style>
459 <style name="LocationBarButton"> 459 <style name="LocationBarButton">
460 <item name="android:background">@null</item> 460 <item name="android:background">@null</item>
461 </style> 461 </style>
462 <style name="ToolbarButton"> 462 <style name="ToolbarButton">
463 <item name="android:background">?attr/selectableItemBackground</item> 463 <item name="android:background">?attr/selectableItemBackground</item>
464 <item name="android:layout_width">48dp</item> 464 <item name="android:layout_width">48dp</item>
465 <item name="android:layout_height">56dp</item> 465 <item name="android:layout_height">56dp</item>
466 <item name="android:scaleType">center</item> 466 <item name="android:scaleType">center</item>
467 </style> 467 </style>
468 <style name="AppMenuItem">
469 <item name="android:paddingStart">16dp</item>
470 <item name="android:paddingEnd">16dp</item>
471 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>
472 </style>
473 <style name="UpdateMenuBadge">
474 <item name="android:layout_height">@dimen/menu_badge_size</item>
475 <item name="android:layout_width">@dimen/menu_badge_size</item>
476 <item name="android:layout_gravity">end|bottom</item>
477 <item name="android:layout_marginBottom">14dp</item>
478 <item name="android:focusable">false</item>
479 <item name="android:importantForAccessibility">no</item>
480 <item name="android:visibility">invisible</item>
481 </style>
468 </resources> 482 </resources>
OLDNEW
« no previous file with comments | « chrome/android/java/res/menu/main_menu.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698