Chromium Code Reviews Chromium Code Reviews
Issue 1505913003:
Add update menu item and app menu icon badge (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 7114c09100261a8645c16bf02149e0dbf6a36e71..85074072fe75f722859195a9aa92decd39358755 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -14673,6 +14673,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="GoogleUpdate.MenuItem.ActionTakenAfterItemClicked" |
| + enum="GoogleUpdateAfterItemClickedActions"> |
| + <owner>twellington@chromium.org</owner> |
| + <summary> |
| + (Android-only) Records whether Chrome was updated after the update menu item |
| + was clicked. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="GoogleUpdate.MenuItem.ActionTakenOnMenuOpen" |
| + enum="GoogleUpdateMenuItemActions"> |
| + <owner>twellington@chromium.org</owner> |
| + <summary> |
| + (Android-only) Records whether the update menu item was clicked when the app |
| + menu was opened. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="GoogleUpdate.UnexpectedState"> |
| <owner>grt@chromium.org</owner> |
| <summary> |
| @@ -65327,6 +65345,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="13" label="WEB_LOGIN_REQUIRED"/> |
| </enum> |
| +<enum name="GoogleUpdateAfterItemClickedActions" type="int"> |
| + <int value="0" label="Updated"/> |
| + <int value="1" label="Not updated"/> |
| +</enum> |
| + |
| <enum name="GoogleUpdateErrorCode" type="int"> |
| <int value="0" label="GOOGLE_UPDATE_NO_ERROR"/> |
| <int value="1" label="CANNOT_UPGRADE_CHROME_IN_THIS_DIRECTORY"/> |
| @@ -65347,6 +65370,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="3" label="InfoBar dismissed implicitly (no interaction)"/> |
| </enum> |
| +<enum name="GoogleUpdateMenuItemActions" type="int"> |
| + <int value="0" label="Clicked, intent launched"/> |
| + <int value="1" label="Clicked, intent failed"/> |
| + <int value="2" label="Not clicked"/> |
|
gone
2015/12/08 22:24:25
nit: Feels like "Not clicked" should be 0.
Theresa
2015/12/10 03:53:18
Done.
|
| +</enum> |
| + |
| <enum name="GoogleUpdateUpgradeStatus" type="int"> |
| <int value="0" label="UPGRADE_STARTED"/> |
| <int value="1" label="UPGRADE_CHECK_STARTED"/> |
