Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: include/v8.h

Issue 15059016: Deprecate the version of Context::New which returns a Persistent. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4591 matching lines...) Expand 10 before | Expand all | Expand 10 after
4602 * template. The state of the global object will be completely reset 4602 * template. The state of the global object will be completely reset
4603 * and only object identify will remain. 4603 * and only object identify will remain.
4604 */ 4604 */
4605 static Local<Context> New( 4605 static Local<Context> New(
4606 Isolate* isolate, 4606 Isolate* isolate,
4607 ExtensionConfiguration* extensions = NULL, 4607 ExtensionConfiguration* extensions = NULL,
4608 Handle<ObjectTemplate> global_template = Handle<ObjectTemplate>(), 4608 Handle<ObjectTemplate> global_template = Handle<ObjectTemplate>(),
4609 Handle<Value> global_object = Handle<Value>()); 4609 Handle<Value> global_object = Handle<Value>());
4610 4610
4611 /** Deprecated. Use Isolate version instead. */ 4611 /** Deprecated. Use Isolate version instead. */
4612 // TODO(mstarzinger): Put this behind the V8_DEPRECATED guard. 4612 V8_DEPRECATED(static Persistent<Context> New(
4613 static Persistent<Context> New(
4614 ExtensionConfiguration* extensions = NULL, 4613 ExtensionConfiguration* extensions = NULL,
4615 Handle<ObjectTemplate> global_template = Handle<ObjectTemplate>(), 4614 Handle<ObjectTemplate> global_template = Handle<ObjectTemplate>(),
4616 Handle<Value> global_object = Handle<Value>()); 4615 Handle<Value> global_object = Handle<Value>()));
4617 4616
4618 /** Returns the last entered context. */ 4617 /** Returns the last entered context. */
4619 static Local<Context> GetEntered(); 4618 static Local<Context> GetEntered();
4620 4619
4621 // TODO(svenpanne) Actually deprecate this. 4620 // TODO(svenpanne) Actually deprecate this.
4622 /** Deprecated. Use Isolate::GetCurrentContext instead. */ 4621 /** Deprecated. Use Isolate::GetCurrentContext instead. */
4623 static Local<Context> GetCurrent(); 4622 static Local<Context> GetCurrent();
4624 4623
4625 /** 4624 /**
4626 * Returns the context of the calling JavaScript code. That is the 4625 * Returns the context of the calling JavaScript code. That is the
(...skipping 1337 matching lines...) Expand 10 before | Expand all | Expand 10 after
5964 5963
5965 5964
5966 } // namespace v8 5965 } // namespace v8
5967 5966
5968 5967
5969 #undef V8EXPORT 5968 #undef V8EXPORT
5970 #undef TYPE_CHECK 5969 #undef TYPE_CHECK
5971 5970
5972 5971
5973 #endif // V8_H_ 5972 #endif // V8_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698