Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 15059009: Enable native implementation of array buffer and typed arrays in d8 and tests. (Closed)

Created:
7 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Enable native implementation of array buffer and typed arrays in d8 and tests. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14646

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/d8.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/cctest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +4 lines, -0 lines 1 comment Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -0 lines 1 comment Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
This makes a switch in d8 and cctests. Implementation in d8.cc is now dead code ...
7 years, 7 months ago (2013-05-08 14:08:10 UTC) #1
Michael Starzinger
LGTM with two nits. https://codereview.chromium.org/15059009/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/15059009/diff/1/test/cctest/test-api.cc#newcode12060 test/cctest/test-api.cc:12060: // FunctionEntryHook does not work ...
7 years, 7 months ago (2013-05-13 13:58:42 UTC) #2
Dmitry Lomov (no reviews)
Thanks for review, added more expanded comments, landing On 2013/05/13 13:58:42, Michael Starzinger wrote: > ...
7 years, 7 months ago (2013-05-13 14:17:23 UTC) #3
Dmitry Lomov (no reviews)
7 years, 7 months ago (2013-05-13 14:18:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r14646 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698