Issue 15059002: Convert build/linux/install-debian.wheezy.sysroot.wrapper.sh to python for Windows compatibility.

Issue 15059002: Convert build/linux/install-debian.wheezy.sysroot.wrapper.sh to python for Windows compatibility. (Closed)

Created:
7 years, 7 months ago by Lei Zhang

Modified:
7 years, 7 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Convert build/linux/install-debian.wheezy.sysroot.wrapper.sh to python for Windows compatibility. BUG=224487 TBR=dbeam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198859

Patch Set 2 : remove unused variable #

Total comments: 8

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -39 lines)			Patch
M	DEPS	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	build/linux/install-debian.wheezy.sysroot.wrapper.py	View	1	2 chunks	+27 lines, -9 lines	8 comments	Download
D	build/linux/install-debian.wheezy.sysroot.wrapper.sh	View		1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

I probably shouldn't have said I've written python :P https://codereview.chromium.org/15059002/diff/3001/build/linux/install-debian.wheezy.sysroot.wrapper.py File build/linux/install-debian.wheezy.sysroot.wrapper.py (right): https://codereview.chromium.org/15059002/diff/3001/build/linux/install-debian.wheezy.sysroot.wrapper.py#newcode21 build/linux/install-debian.wheezy.sysroot.wrapper.py:21: ...

7 years, 7 months ago (2013-05-08 08:33:30 UTC) #4

Lei Zhang

https://codereview.chromium.org/15059002/diff/3001/build/linux/install-debian.wheezy.sysroot.wrapper.py File build/linux/install-debian.wheezy.sysroot.wrapper.py (right): https://codereview.chromium.org/15059002/diff/3001/build/linux/install-debian.wheezy.sysroot.wrapper.py#newcode21 build/linux/install-debian.wheezy.sysroot.wrapper.py:21: import subprocess On 2013/05/08 08:33:30, Dan Beam wrote: > ...

7 years, 7 months ago (2013-05-08 08:42:10 UTC) #5

Dan Beam

7 years, 7 months ago (2013-05-08 09:06:47 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/15059002/diff/3001/build/linux/install-debian...
File build/linux/install-debian.wheezy.sysroot.wrapper.py (right):

https://codereview.chromium.org/15059002/diff/3001/build/linux/install-debian...
build/linux/install-debian.wheezy.sysroot.wrapper.py:21: import subprocess
On 2013/05/08 08:42:10, Lei Zhang wrote:
> On 2013/05/08 08:33:30, Dan Beam wrote:
> > not sure if we're supposed to be using subproccess or subprocess2 here...
> 
> Isn't subprocess2 in depot_tools? Everything in src/build use subprocess.

ah, ok, ignore me then

Expand Messages | Collapse Messages