Lower the priority of environment and process data collection.

chrome/browser/safe_browsing/incident_reporting/environment_data_collection.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/incident_reporting/environment_data_collection.h"
 
 #include <string>
 
 #include "base/cpu.h"
 #include "base/sys_info.h"
+#include "base/threading/platform_thread.h"
+#include "base/threading/sequenced_worker_pool.h"
 #include "chrome/common/channel_info.h"
 #include "chrome/common/safe_browsing/csd.pb.h"
 #include "components/version_info/version_info.h"
 
 namespace safe_browsing {
 
 // Populates |process| with platform-specific data related to the chrome browser
 // process.
 void CollectPlatformProcessData(
     ClientIncidentReport_EnvironmentData_Process* process);
@@ skipping 34 matching lines @@
 
   process->set_chrome_update_channel(
       MapChannelToProtobuf(chrome::GetChannel()));
 
   CollectPlatformProcessData(process);
 }
 
 }  // namespace
 
 void CollectEnvironmentData(ClientIncidentReport_EnvironmentData* data) {
+  // Toggling priority only makes sense in a thread pool.
+  DCHECK(base::SequencedWorkerPool::GetWorkerPoolForCurrentThread());
+  // Lower priority for this task.
+  auto previous_priority = base::PlatformThread::GetCurrentThreadPriority();
+  base::PlatformThread::SetCurrentThreadPriority(
+      base::ThreadPriority::BACKGROUND);
+
   // OS
   {
     ClientIncidentReport_EnvironmentData_OS* os = data->mutable_os();
     os->set_os_name(base::SysInfo::OperatingSystemName());
     os->set_os_version(base::SysInfo::OperatingSystemVersion());
     CollectPlatformOSData(os);
   }
 
   // Machine
   {
     base::CPU cpu_info;
     ClientIncidentReport_EnvironmentData_Machine* machine =
         data->mutable_machine();
     machine->set_cpu_architecture(base::SysInfo::OperatingSystemArchitecture());
     machine->set_cpu_vendor(cpu_info.vendor_name());
     machine->set_cpuid(cpu_info.signature());
   }
 
   // Process
   CollectProcessData(data->mutable_process());
+
+  // Reset the thread priority.
+  base::PlatformThread::SetCurrentThreadPriority(previous_priority);

[grt (UTC plus 2), 2015/12/14 21:10:25]

it would be hella bad if someone accidentally added a "return;" before this.
would you mind using base::ScopedClosureRunner up on line 73 to ensure that the
priority is always reverted? does this work:
  base::ScopedClosureRunner restore_priority(
      base::Bind(&base::PlatformThread::SetCurrentThreadPriority,
                 previous_priority));

[gab, 2015/12/15 16:49:38]

That sounds like a great idea to me, also keeps all priority related code at the
top :-). I felt like adding a new scoper for thread priority just for this CL
was overkill so I had refrained from asking but I didn't know about
ScopedClosureRunner :-), very useful for generic scopers!).

[proberge, 2015/12/16 15:19:38]

Done.

 }
 
 #if !defined(OS_WIN)
 void CollectPlatformProcessData(
     ClientIncidentReport_EnvironmentData_Process* process) {
   // Empty implementation for platforms that do not (yet) have their own
   // implementations.
 }
 
 void CollectPlatformOSData(ClientIncidentReport_EnvironmentData_OS* os_data) {
   // Empty implementation for platforms that do not (yet) have their own
   // implementations.
 }
 #endif
 
 }  // namespace safe_browsing