cc: Rename VSync to BeginFrame

cc/output/output_surface.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_OUTPUT_OUTPUT_SURFACE_H_
 #define CC_OUTPUT_OUTPUT_SURFACE_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "cc/base/cc_export.h"
@@ skipping 78 matching lines @@
 
   virtual void BindFramebuffer();
 
   virtual void PostSubBuffer(gfx::Rect rect, const LatencyInfo&);
   virtual void SwapBuffers(const LatencyInfo&);
 
   // Notifies frame-rate smoothness preference. If true, all non-critical
   // processing should be stopped, or lowered in priority.
   virtual void UpdateSmoothnessTakesPriority(bool prefer_smoothness) {}
 
-  // Requests a vsync notification from the output surface. The notification
-  // will be delivered by calling OutputSurfaceClient::DidVSync for all future
-  // vsync events until the callback is disabled.
-  virtual void EnableVSyncNotification(bool enable_vsync) {}
+  // Requests a BeginFrame notification from the output surface. The
+  // notification will be delivered by calling OutputSurfaceClient::BeginFrame
+  // until the callback is disabled.
+  virtual void EnableBeginFrameNotification(bool enable) {}

[Sami, 2013/05/15 12:11:20]

Should we rename this to SetNeedsBeginFrame (here and elsewhere) to match the
design even though the semantics are still a little different (BeginFrame isn't
necessarily sent periodically).

[brianderson, 2013/05/15 18:03:30]

Consistency is good, so I will change this to SetNeedsBeginFrame.

 
  protected:
   OutputSurfaceClient* client_;
   struct cc::OutputSurface::Capabilities capabilities_;
   scoped_ptr<WebKit::WebGraphicsContext3D> context3d_;
   scoped_ptr<cc::SoftwareOutputDevice> software_device_;
   bool has_gl_discard_backbuffer_;
 
   scoped_ptr<OutputSurfaceCallbacks> callbacks_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(OutputSurface);
 };
 
 }  // namespace cc
 
 #endif  // CC_OUTPUT_OUTPUT_SURFACE_H_