mojo/devtools/common/devtoolslib/android_shell.py - Issue 1505783002: Improve the fifo open timeout error message in `android_shell.py`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/devtools/common/devtoolslib/android_shell.py

Issue 1505783002: Improve the fifo open timeout error message in `android_shell.py`. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/devtools/common/devtoolslib/android_shell.py

diff --git a/mojo/devtools/common/devtoolslib/android_shell.py b/mojo/devtools/common/devtoolslib/android_shell.py

index 178934a7cfc854798f7ebf4641cc9fe393557160..dfa0c8449daaaae15525b39d5f9527e4da0d2624 100644

--- a/mojo/devtools/common/devtoolslib/android_shell.py

+++ b/mojo/devtools/common/devtoolslib/android_shell.py

@@ -126,7 +126,7 @@ class AndroidShell(Shell):

time.sleep(1)

if on_fifo_closed:

on_fifo_closed()

- raise Exception('Unable to find fifo.')

+ raise Exception('Timed out waiting for shell the create the fifo file.')

_wait_for_fifo()

stdout_cat = subprocess.Popen(

self._adb_command(['shell', 'run-as', _MOJO_SHELL_PACKAGE_NAME,

« no previous file with comments | « no previous file | no next file » | no next file with comments »