SkDocument::setDCTEncoder() for old versions of webkit

SkDocument::setDCTEncoder() for old versions of webkit

Committed: https://skia.googlesource.com/skia/+/712fdf7603c62820b21174da9b0a2071c174936b

[hal.canary, 2015-12-07 19:32:03]

halcanary@google.com changed reviewers:
+ benjaminwagner@google.com

[hal.canary, 2015-12-07 19:32:04]

PTAL.  Does this do what you need?

[dogben, 2015-12-07 19:49:16]

On 2015/12/07 at 19:32:04, halcanary wrote:
> PTAL.  Does this do what you need?

Yep, thanks!

[hal.canary, 2015-12-07 20:01:03]

unit test added, #define removed

[dogben, 2015-12-07 20:34:18]

lgtm

You should probably update the CL description.

One ignorable comment below.

https://codereview.chromium.org/1505763003/diff/20001/tests/PDFDocumentTest.cpp
File tests/PDFDocumentTest.cpp (right):

https://codereview.chromium.org/1505763003/diff/20001/tests/PDFDocumentTest.c...
tests/PDFDocumentTest.cpp:122: ? SkImageEncoder::EncodeData(bm,
SkImageEncoder::kJPEG_Type, 85)
nit: Why not use the other override of EncodeData?

[hal.canary, 2015-12-07 20:50:05]

Description was changed from

==========
SK_PDF_DCT_ENCODER for old versions of webkit
==========

to

==========
SkDocument::setDCTEncoder() for old versions of webkit
==========

[hal.canary, 2015-12-07 20:51:35]

halcanary@google.com changed reviewers:
+ reed@google.com

[hal.canary, 2015-12-07 20:51:35]

reed@: PTAL @ API.  mtklein@ proposed taking the encoder as an option to
SkDocument::CreatePDF().  What do you think?

[hal.canary, 2015-12-08 22:06:56]

On 2015/12/07 at 20:51:35, Hal Canary wrote:
> reed@: PTAL @ API.  mtklein@ proposed taking the encoder as an option to
SkDocument::CreatePDF().  What do you think?

Please see changes to SkDocument.h

[reed1, 2015-12-10 01:06:06]

lgtm

[hal.canary, 2015-12-10 16:36:15]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-12-10 16:36:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjaminwagner@google.com
Link to the patchset: https://codereview.chromium.org/1505763003/#ps60001
(title: "2015-12-09 (Wednesday) 13:41:21 EST")

[commit-bot: I haz the power, 2015-12-10 16:36:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505763003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505763003/60001

[commit-bot: I haz the power, 2015-12-10 16:59:45]

Description was changed from

==========
SkDocument::setDCTEncoder() for old versions of webkit
==========

to

==========
SkDocument::setDCTEncoder() for old versions of webkit

Committed:
https://skia.googlesource.com/skia/+/712fdf7603c62820b21174da9b0a2071c174936b
==========

[commit-bot: I haz the power, 2015-12-10 16:59:45]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/712fdf7603c62820b21174da9b0a2071c174936b