Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1505763002: Use generic icu:: prefix instead of icu_54:: in autofill_l10n_util.cc (Closed)

Created:
5 years ago by Paweł Hajdan Jr.
Modified:
5 years ago
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, jshin+watch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use generic icu:: prefix instead of icu_54:: in autofill_l10n_util.cc This was introduced in https://codereview.chromium.org/1457393003 but makes it more difficult to use system ICU. This CL makes it work easily both with bundled and system ICU. BUG=none Committed: https://crrev.com/df29c8028d28372475a2b827fd63f4510ed1f6ee Cr-Commit-Position: refs/heads/master@{#363468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/autofill/core/common/autofill_l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Paweł Hajdan Jr.
5 years ago (2015-12-07 12:34:22 UTC) #2
vabr (Chromium)
LGTM, icu:: is apparently used everywhere else in autofill and the whole Chromium. Just curious ...
5 years ago (2015-12-07 13:14:57 UTC) #4
Mathieu
lgtm, sorry for the hassle
5 years ago (2015-12-07 13:37:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505763002/1
5 years ago (2015-12-07 13:41:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 13:45:59 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-07 13:46:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df29c8028d28372475a2b827fd63f4510ed1f6ee
Cr-Commit-Position: refs/heads/master@{#363468}

Powered by Google App Engine
This is Rietveld 408576698