Add OnRequestCanvasDrawListener

Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=524218
TEST=Ran the demo below with MediaCaptureFromElement flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture6.html

Committed: https://crrev.com/cd1d0628f2760608c792391d31b5cd2c1b98a2a8
Cr-Commit-Position: refs/heads/master@{#367124}

[emircan, 2015-12-08 06:30:04]

Description was changed from

==========
ondemand

BUG=
==========

to

==========
Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=254990
TEST=Ran the demos listed in [0] with MediaCaptureFromElement flag enabled.
[0]
https://docs.google.com/document/d/1JmWfOtUP6ZqsYJ--U8y0OtHkBt-VyjX4N-JqIjb1t...
==========

[emircan, 2015-12-08 06:30:04]

emircan@chromium.org changed reviewers:
+ esprehn@chromium.org

[emircan, 2015-12-08 06:30:23]

PTAL.

[emircan, 2015-12-08 18:10:10]

Description was changed from

==========
Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=254990
TEST=Ran the demos listed in [0] with MediaCaptureFromElement flag enabled.
[0]
https://docs.google.com/document/d/1JmWfOtUP6ZqsYJ--U8y0OtHkBt-VyjX4N-JqIjb1t...
==========

to

==========
Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=524218
TEST=Ran the demos listed in [0] with MediaCaptureFromElement flag enabled.
[0]
https://docs.google.com/document/d/1JmWfOtUP6ZqsYJ--U8y0OtHkBt-VyjX4N-JqIjb1t...
==========

[emircan, 2015-12-08 22:14:05]

Description was changed from

==========
Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=524218
TEST=Ran the demos listed in [0] with MediaCaptureFromElement flag enabled.
[0]
https://docs.google.com/document/d/1JmWfOtUP6ZqsYJ--U8y0OtHkBt-VyjX4N-JqIjb1t...
==========

to

==========
Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=524218
TEST=Ran the demo below with MediaCaptureFromElement flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture6.html
==========

[emircan, 2015-12-10 01:10:19]

Patchset #2 (id:20001) has been deleted

[emircan, 2015-12-10 01:14:04]

emircan@chromium.org changed reviewers:
+ hta@chromium.org

[esprehn, 2015-12-11 10:32:04]

lgtm

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.cpp
(right):

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.cpp:25:
return CanvasDrawListener::needsNewFrame();
return m_requestFrame && CanvasDrawListener::needsNewFrame();

remove if

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.cpp:42:
:CanvasDrawListener(handler)
put this at the top near create?

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h
(right):

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h:18:
~OnRequestCanvasDrawListener() {}
does the destructor really need to be inline?

[emircan, 2015-12-11 19:50:32]

Patchset #3 (id:60001) has been deleted

[emircan, 2015-12-11 19:51:09]

Thanks.

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.cpp
(right):

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.cpp:25:
return CanvasDrawListener::needsNewFrame();
On 2015/12/11 10:32:04, esprehn wrote:
> return m_requestFrame && CanvasDrawListener::needsNewFrame();
> 
> remove if

Done.

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.cpp:42:
:CanvasDrawListener(handler)
On 2015/12/11 10:32:03, esprehn wrote:
> put this at the top near create?

Done.

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h
(right):

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h:18:
~OnRequestCanvasDrawListener() {}
On 2015/12/11 10:32:04, esprehn wrote:
> does the destructor really need to be inline?

Not really. Default dtor would be fine, I am removing it.

[emircan, 2015-12-11 20:01:56]

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h
(right):

https://codereview.chromium.org/1505753005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h:18:
~OnRequestCanvasDrawListener() {}
On 2015/12/11 19:51:09, emircan wrote:
> On 2015/12/11 10:32:04, esprehn wrote:
> > does the destructor really need to be inline?
> 
> Not really. Default dtor would be fine, I am removing it.

Adding it back after offline discussion.

[emircan, 2015-12-30 01:39:05]

The CQ bit was checked by emircan@chromium.org

[emircan, 2015-12-30 01:39:07]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1505753005/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-12-30 01:39:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505753005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505753005/120001

[commit-bot: I haz the power, 2015-12-30 01:45:25]

Description was changed from

==========
Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=524218
TEST=Ran the demo below with MediaCaptureFromElement flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture6.html
==========

to

==========
Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=524218
TEST=Ran the demo below with MediaCaptureFromElement flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture6.html
==========

[commit-bot: I haz the power, 2015-12-30 01:45:26]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-12-30 01:46:13]

Description was changed from

==========
Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=524218
TEST=Ran the demo below with MediaCaptureFromElement flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture6.html
==========

to

==========
Add OnRequestCanvasDrawListener

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=524218
TEST=Ran the demo below with MediaCaptureFromElement flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture6.html

Committed: https://crrev.com/cd1d0628f2760608c792391d31b5cd2c1b98a2a8
Cr-Commit-Position: refs/heads/master@{#367124}
==========

[commit-bot: I haz the power, 2015-12-30 01:46:14]

Patchset 5 (id:??) landed as
https://crrev.com/cd1d0628f2760608c792391d31b5cd2c1b98a2a8
Cr-Commit-Position: refs/heads/master@{#367124}