Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1505743003: Change the order the classes are expected to be found by serialize_test (Closed)

Created:
5 years ago by sigurdm
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change the order the classes are expected to be found by serialize_test This solves test failure triggered by: https://codereview.chromium.org/1498963004/ Fixes issue #25125 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/50b17cf222eef89333433969887c3c57e0dc9825

Patch Set 1 #

Patch Set 2 : Adjust status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M tests/try/poi/serialize_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/try/try.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sigurdm
5 years ago (2015-12-07 15:00:47 UTC) #2
Florian Schneider
Don't forget to update the try.status file and the issue #25125
5 years ago (2015-12-07 15:02:18 UTC) #4
sigurdm
Good point, thanks!
5 years ago (2015-12-07 15:07:18 UTC) #6
Florian Schneider
lgtm
5 years ago (2015-12-07 15:07:54 UTC) #7
sigurdm
Committed patchset #2 (id:20001) manually as 50b17cf222eef89333433969887c3c57e0dc9825 (presubmit successful).
5 years ago (2015-12-07 15:29:32 UTC) #9
Bill Hesse
5 years ago (2015-12-07 15:36:45 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698