Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1833)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 150573014: Rename various methods in webkitpy.layout_test.Port to be public (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove port.check_httpd stub call from port_testcase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/port/win.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/win.py b/Tools/Scripts/webkitpy/layout_tests/port/win.py
index 88e8d0de15e3ef0de01ea1ae4019f43f1fbb7b63..22970811eb518bc4948d81587c24d5b6f0b4a118 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/win.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/win.py
@@ -144,31 +144,31 @@ class WinPort(base.Port):
path = filename[len(self.layout_tests_dir()) + 1:]
return path.replace('\\', '/')
- #
- # PROTECTED ROUTINES
- #
-
- def _uses_apache(self):
+ def uses_apache(self):
return False
- def _lighttpd_path(self, *comps):
- return self.path_from_chromium_base('third_party', 'lighttpd', 'win', *comps)
-
- def _path_to_apache(self):
+ def path_to_apache(self):
return self.path_from_chromium_base('third_party', 'cygwin', 'usr', 'sbin', 'httpd')
- def _path_to_apache_config_file(self):
+ def path_to_apache_config_file(self):
return self._filesystem.join(self.layout_tests_dir(), 'http', 'conf', 'cygwin-httpd.conf')
- def _path_to_lighttpd(self):
+ def path_to_lighttpd(self):
return self._lighttpd_path('LightTPD.exe')
- def _path_to_lighttpd_modules(self):
+ def path_to_lighttpd_modules(self):
return self._lighttpd_path('lib')
- def _path_to_lighttpd_php(self):
+ def path_to_lighttpd_php(self):
return self._lighttpd_path('php5', 'php-cgi.exe')
+ #
+ # PROTECTED ROUTINES
+ #
+
+ def _lighttpd_path(self, *comps):
+ return self.path_from_chromium_base('third_party', 'lighttpd', 'win', *comps)
+
def _path_to_driver(self, configuration=None):
binary_name = '%s.exe' % self.driver_name()
return self._build_path_with_configuration(configuration, binary_name)
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698