Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

Issue 1505713002: Include glyph overflow in SVG text bounding boxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compute and store glyph overflow per-fragment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
index 66d12909439a71e6581751170de0438ae07a0cd6..0ae65cce7d0a24c8407049b08f717c4c44a1cf51 100644
--- a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
@@ -49,11 +49,11 @@ public:
void setWidth(float width) { m_width = width; }
float height() const { return m_height; }
+
// TODO(kojii): We should store logical width (advance) and height instead
// of storing physical and calculate logical. crbug.com/544767
float advance(FontOrientation) const;
unsigned length() const { return m_length; }
-
fs 2015/12/14 09:59:31 Nit: I like the new blank line, but I think I'd li
pdr. 2015/12/16 04:27:45 Sigh, I was going to use this one in a followup pa
private:
SVGTextMetrics(LineLayoutSVGInlineText, const TextRun&);

Powered by Google App Engine
This is Rietveld 408576698